Channels
announcements
ask-marvin
best-practices-coordination-plane
data-ecosystem
data-tricks-and-tips
events
find-a-prefect-job
geo-bay-area
geo-berlin
geo-boston
geo-chicago
geo-colorado
geo-dc
geo-israel
geo-japan
geo-london
geo-nyc
geo-seattle
geo-texas
gratitude
introductions
marvin-in-the-wild
pacc-clearcover-june-12-2023
pacc-may-31-2023
ppcc-may-16-2023
prefect-ai
prefect-aws
prefect-azure
prefect-cloud
prefect-community
prefect-contributors
prefect-dbt
prefect-docker
prefect-gcp
prefect-getting-started
prefect-integrations
prefect-kubernetes
prefect-recipes
prefect-server
prefect-ui
random
show-us-what-you-got
Title
p
Praveen Shilavantar
12/19/2022, 10:03 PMHi, is it posisble to add @flow to existing class methods?
class API:@flowdef start(self):pass✅ 1
z
Zanie
12/19/2022, 10:09 PMHi! We generally don’t support this. You can do something like
from prefect import flow
class Foo:
@flow
def hi(self, name):
print("hi", name)
foo = Foo()
Foo.hi(foo, name="test")p
Praveen Shilavantar
12/19/2022, 10:14 PMThanks how do we add class method a task?
class Foo:
@task
def greetings(self, name):
print("Hello", name)
@flow
def hi(self, name):
print("hi", name)
self.greetings(name)
foo = Foo()
Foo.hi(foo, name="test")Is it not a blocker for people who already coded using class methods in existing projects? how it is supported?
z
Zanie
12/19/2022, 10:24 PMWe don’t recommend using class methods because statefulness is not guaranteed
For example, if your task is submitted to a worker when it mutates
self.some_attributeA while ago, a user opened a pull request to just immediately error when sometime tries to decorate a class method: https://github.com/PrefectHQ/prefect/pull/6864
fwiw from your example…
from prefect import flow, task
class Foo:
@flow
def hi(self, name):
print("hi", name)
Foo.bye(self)
@task
def bye(self):
print("bye")
foo = Foo()
Foo.hi(foo, name="test")👍 1
I doubt we will add first-class support here anytime soon as it’s going to cause more confusing behavior than it’s worth.
p
Praveen Shilavantar
12/19/2022, 10:46 PMGot it thanks