hey everyone! i'm trying to add the Prefect Server Helm chart as a dependency to an existing helm chart. If I want to prefix/rename EVERYTHING that is in the Prefect Server helm chart, is there an easy way to do that?

Hi, we generate names with the following utilities https://github.com/PrefectHQ/server/blob/master/helm/prefect-server/templates/_helpers.tpl#L21-L42

i saw that, but it was a tid bit headscratching, with respect to

namePrefix

nameSuffix

too... in my top-level chart, should i set

nameOverride

or

namePrefix

or

nameSuffix

for each component?

Yeah 😄

exactly, so my Chart.yml looks something like this:

apiVersion: v2
name: my-app
type: application
version: 0.0.0
appVersion: "1.16.0"
...
dependencies:
  - name: postgresql
    version: "~9.3.2"
    repository: <https://charts.bitnami.com/bitnami>
    condition: postgresql.useSubChart
  - name: prefect-server
    version: "2022.01.25"
    repository: <https://prefecthq.github.io/server/>

so currently its colliding on the service account name and postgres (and we already have a component called ui as well) i think prefect's helm is trying to make

my-app-postgresql

which is already taken by

my-app

Hmmm

i think this is the possible issue: https://github.com/PrefectHQ/server/blob/master/helm/prefect-server/templates/_helpers.tpl#L27 i believe the helper is taking

.Chart.Name

or which is in this case,

my-app

, and only allowing

.Values.nameOverride

as an alternative?

What happens if you provide a nameOverride to the server chart?

in my top level values.yaml, i've been playing with something like this...

prefect-server:
  nameOverride: prefect-server
  useSubChart: false
  postgresql:
    nameOverride: prefect-server-postgresql
  serviceAccount:
    name: prefect-server

but that nested nameOverride seems to have no effect? (PSA I'm new to the way values.yaml are munged for subcharts)

Yeah only the top-level name override will do anything

ahh dang 😕

I think https://github.com/PrefectHQ/server/pull/355 will fix this issue

that looks pretty good, wouldn't we want an option of somekind to conditionally do the new naming, for backwards compatibility?

Perhaps, I’m not actually sure how helm will behave on upgrade when names change

i believe the service yamls use

nameField

as well, so in theory the generated DNS name would likely change, that might break anyone that's hardcoded the DNS name of apollo, for example

Ah yes, hm. I’m not really enthused about including a boolean. I’ll see what the rest of the team thinks.

gotcha, i understand! let me know what the rest of the team thinks!

I’ve added a toggle to the PR for backwards compatibility

wonderful thanks!! does this land in the Helm Repo once its pushed to master?

No, I’ll cut a new server release today though

🚀 you rock thanks!