Bring your towel and join one of the fastest growing data communities. Welcome to our second-generation open source orchestration platform, a completely rethought approach to dataflow automation.

Prefect Community

Hi, I have <https://github.com/PrefectHQ/prefect/pull/10404|this> MR failing unit testing with the folowing error message:

`botocore.exceptions.NoCredentialsError: Unable to locate credentials`

I think it's because of <https://github.com/manaw/prefect-fork/blob/014f048ef056e799be3dd6dd8b6be2a2f94319cc/tests/results/test_result_factory.py#L91|this> line referencing S3, but cannot say for sure. I though I'd reach out the community before requesting another review.

<@U02GMEZU18B> sorry to drag you in, I met you in last month's prefect course. Any suggestions here?

hi <@U05NVLR10KV> - my feeling is that if this is something we're going to test, we would want to mock out any call to a remote filesystem. there should not be any need to actually talk to s3 from our unit tests

actually this test might be instructive

<https://github.com/PrefectHQ/prefect/blob/main/tests/test_filesystems.py#L375>

seems like we could use a `RemoteFileSystem` in memory like that instead of worrying about mocking

Thanks for your response, I just successfully tested locally and was just about to message you to approve the tests for review:

<https://github.com/PrefectHQ/prefect/pull/10404>

oh nice, and you used it in memory too - jinx! :slightly_smiling_face:

:eyes:

Hi <@U02GMEZU18B> :wave: I pushed some changes on Thursday, any chance you might be able to kick off a review?

im a bit confused about your recent change
```-    fs = RemoteFileSystem(basepath="<memory://root>")
+    fs = LocalFileSystem(basepath="memory/root")```
`memory/root` is not a valid `block-type/block-document-name` ,  nor is it a valid `basepath` that specifies a protocol

i would think the eventual implementation would have `PREFECT_DEFAULT_RESULT_STORAGE_BLOCK` accepting a block type/document slug, as the name suggests, like
`s3/my-result-storage` and then maybe this would be more like
```    return (
        Block.load(PREFECT_DEFAULT_RESULT_STORAGE_BLOCK.value())
        if PREFECT_DEFAULT_RESULT_STORAGE_BLOCK.value() is not None
        else LocalFileSystem(basepath=PREFECT_LOCAL_STORAGE_PATH.value())
    )```