Hi y’all. Did something change with the Slack notifications? I’m getting these: ```/my_path/.venv/li...

kiran

01/31/2023, 5:06 PM

Hi y’all. Did something change with the Slack notifications? I’m getting these:

Copy code

/my_path/.venv/lib/python3.10/site-packages/prefect/utilities/dispatch.py:162: UserWarning: Type 'SlackWebhook' at /my_path/.venv/lib/python3.10/site-packages/prefect_slack/credentials.py:43 has key 'slack-webhook' that matches existing registered type 'SlackWebhook' from /my_path/.venv/lib/python3.10/site-packages/prefect/blocks/notifications.py:83. The existing type will be overridden.

Copy code

TypeError: Block.__new__() takes 1 positional argument but 2 were given

But the writing here still seems to be like how I’ve been using it (not using a Block). Maybe I missed another documentation update somewhere? Using: prefect 2.7.10 prefect-slack 0.1.1

✅ 1

Zanie

01/31/2023, 5:12 PM

cc @Andrew Huang

kiran

01/31/2023, 5:15 PM

Just tried this from @Anna Geller (thanks!) and it works but I’m still getting the warning. Which, I suppose, is fine at the moment, if it’s just a warning

kiran

01/31/2023, 5:21 PM

FWIW, I seem to also be able to get it to work using:

Copy code

# from prefect.blocks.notifications import SlackWebhook
from prefect_slack import SlackWebhook

but it shows up slightly differently than the other way (from blocks)

kiran

01/31/2023, 5:22 PM

Andrew Huang

01/31/2023, 5:24 PM

SlackWebhook from prefect core is different from prefect-slack in the sense that prefect core’s webhook is powered by Apprise while prefect-slack uses Slack’s python client. I think at one point, we were planning to move the notification blocks out of the core library to reduce dependencies, but with Apprise, it was minimal dependencies to power many notification blocks, so we kept it. however, we should probably document that prefect-slack’s webhook is different and we might want to rename it. I’ll discuss with the team on how we want to approach prefect-slack

kiran

01/31/2023, 5:28 PM

Hi! OK, that’s good to know. Thanks. So it doesn’t matter which one I use (thinking about future)? Also, then, is this documentation no longer accurate? Since it doesn’t have anything about blocks and was giving me that warning and then Type error

Zanie

01/31/2023, 5:28 PM

What’s the expectation when you have both installed?

Zanie

01/31/2023, 5:28 PM

It seems less than ideal that the dispatch keys would collide and that the implementations aren’t compatibile.

Andrew Huang

01/31/2023, 5:30 PM

prefect_slack.SlackWebhook was copied over from prefect.SlackWebhook as it was at the time; however, prefect.SlackWebhook went through some refactoring with Apprise, so now they aren’t the same

kiran

01/31/2023, 5:30 PM

Originally I was just using the SlackCredentials way of doing it as it says in the docs I linked to. I don’t really care which I use, as long as I know which one I should be using (in thinking about the future)

kiran

01/31/2023, 5:30 PM

Copy code

from prefect_slack import SlackCredentials
from prefect_slack.messages import send_chat_message

Andrew Huang

01/31/2023, 5:32 PM

I think send_chat_message task has a bit more functionality, e.g. attachments and slack blocks

Andrew Huang

01/31/2023, 5:35 PM

in the near future, we will be updating SlackWebhook’s block type slug so it doesn’t conflict with the core

kiran

01/31/2023, 5:35 PM

OK. The send_chat_message is what I’ve been using for months and now have started getting the warning and TypeError

Block._new_() takes 1 positional argument but 2 were given

so is there a way around this?

Andrew Huang

01/31/2023, 5:35 PM

in the farther out future, I believe we will be refactoring prefect-slack’s tasks as block methods, maybe SlackMessage()

Andrew Huang

01/31/2023, 5:36 PM

can you share how you instantiate slack_credentials?

kiran

01/31/2023, 5:38 PM

Also, FWIW, I also have been gravitating toward using my own “DataEngineer” slackbot app because I’d been unable to mention my slack user ID or my slack team user ID in failure notifications. I could do this in Prefect 1 but not 2

kiran

01/31/2023, 5:38 PM

Copy code

from prefect import flow
from prefect.blocks.system import Secret
from prefect_slack import SlackCredentials
from prefect_slack.messages import send_chat_message

@flow
def begin_notify_flow(channel_name: str, flow_name: str):
    TOKEN = Secret.load("slack-bot-token").get()

    send_chat_message(
        slack_credentials=SlackCredentials(TOKEN),
        channel=channel_name,
        text=f":`{flow_name}` flow run is starting",
    )

    return

kiran

01/31/2023, 5:39 PM

But this is using my slackbot token

kiran

01/31/2023, 5:41 PM

And, to clarify, I have different “notify flows” because I put them in a try/except so I could get the failures. Since it doesn’t work totally the same as Prefect 1 with the contexts

Andrew Huang

01/31/2023, 5:41 PM

Copy code

SlackCredentials(TOKEN)

do you use

token=TOKEN

I don’t think you can instantiate blocks without kwargs

kiran

01/31/2023, 5:42 PM

I never used it before but I can try now hold on

Andrew Huang

01/31/2023, 5:42 PM

in regards to try/except, I believe you can now use automations

Andrew Huang

01/31/2023, 5:45 PM

for “my slack user ID or my slack team user ID in failure notifications” can you elaborate?

kiran

01/31/2023, 5:47 PM

OK. The

token=TOKEN

worked, when I never had to do it before

kiran

01/31/2023, 5:47 PM

For IDs, I mean that I load in my slack user ID (e.g., 12345AB) and it mentions me when things fail

kiran

01/31/2023, 5:47 PM

But the Prefect notifications write out the actual ID and not

@kiran

kiran

01/31/2023, 5:48 PM

Or at least, that’s what was happening at the beginning of 2.0. I haven’t tried it again lately

kiran

01/31/2023, 5:49 PM

So that’s why I went back to my own slackbot for now

Andrew Huang

01/31/2023, 5:50 PM

I see. Would you mind submitting an issue in prefect-slack and when we refactor we can add that functionality as well?

👍🏾 1

kiran

01/31/2023, 5:53 PM

So, given that it’s now working with

token=TOKEN

and the warning isn’t breaking anything, I think I’ll keep my current way of doing it for now

kiran

01/31/2023, 5:53 PM

Thank you!

🙌 1

kiran

01/31/2023, 6:28 PM

@Andrew Huang I just realized that this issue is the same one but I’m using

prefect==2.7.10

. Do you want me to file a new issue about the warning for that? Also, is there an issue template? (np if there’s not — I just want to make sure to use it if it there is, for the slack mentions issue)

Andrew Huang

01/31/2023, 6:30 PM

I just released prefect-slack v0.1.2 that should fix this atm there is none; haven’t updated it yet

👍🏾 1

kiran

01/31/2023, 6:31 PM

OK I’m going to just completely redo my environment. That’s like turn it off and back on again, right 🙃

kiran

01/31/2023, 6:32 PM

thanks

Andrew Huang

01/31/2023, 6:33 PM

actually one moment…

Andrew Huang

01/31/2023, 6:34 PM

need pypi approval for v0.1.2. should be out in 3 minutes

kiran

01/31/2023, 6:34 PM

ok np. No rush on my end. I have some meetings. I’ll check back later

7 Views

Open in Slack

Previous Next

Prefect Community

Bring your towel and join one of the fastest growing data communities. Welcome to our second-generation open source orchestration platform, a completely rethought approach to dataflow automation.