Hi, is there a way to use the same block for k8s based deployment while passing customisations separately for memory and cpu requests/limits?

Yes there is, see

Thanks @redsquare saw the thread. When you mentioned that you pass it through the code, how do you do that exactly? Like as what variable should I pass it and should it be done in the flow code or somewhere else?

So if you load the block then augment it by adding customisations array to it loaded_block.customizations=[ { "op": "add", "path": "/spec/template/spec/resources", "value": {"limits": {"memory": "8Gi", "cpu": "4000m"}}, } ]

okay which means I will have to use python object for deployment which I have not been able to figure out and hence doing it via CLI 😐 I wanted to create a flow which basically deploys other flows by passing path, flowname and memory/cpu requirements but the python object keeps giving this error

The apply is a property of build from flow

Damn! I tried it just once and that too by looking at the documentation on the page 😞 Thanks a lot

the code I pasted above is wrong, I'll edit when I'm on my laptop

Sure, will wait for that. Thanks a lot!

infra_overrides['customizations']=[ { "op": "add", "path": "/spec/template/spec/resources", "value": {"limits": {"memory": "8Gi", "cpu": "4000m"}}, } ]

So I first create create_query_log_deployments and then add infra_overrides on that. Correct?

You pass it in to the Deployment.build_from_flow

okay, I think I got confused because a part of that screenshot you shared is not visible (right side cropped). If possible, can you share that please?

image.png

Thanks mate. This check_query_log_deployment object I created with added infra_overrides. What next should I do?

No worries, cool you got it sorted

Hey @redsquare, sorry for bothering you again. I followed the steps you mentioned. I passed this as infra_override in build_from_flow but memory requests/limits doesn't seem to work. I checked the details of the pod created but memory limits/requests were not there. Do you maybe know what I am doing wrong?

infra_overrides = {
		  "customizations": [
		    {
		      "op": "add",
		      "path": "/spec/template/spec/resources",
		      "value": {
		        "limits": {
		          "memory": memory_limit,
		          "cpu": cpu_limit
		        },
		        "requests": {
		          "memory": memory_request,
		          "cpu": cpu_request
		        }
		      }
		    }
		  ]
		}

show me exactly how you are doing it

this is the complete code

deployment = Deployment.build_from_flow(
	flow = eval(flow_name),
	description = "Flow in the location - {}:{}".format(script_path, flow_name),
	name = deployment_name,
	infrastructure = KubernetesJob.load("kubejob-base"),
	infra_overrides = {
	  "customizations": [
	    {
	      "op": "add",
	      "path": "/spec/template/spec/resources",
	      "value": {
	        "limits": {
	          "memory": memory_limit,
	          "cpu": cpu_limit
	        },
	        "requests": {
	          "memory": memory_request,
	          "cpu": cpu_request
	        }
	      }
	    }
	  ]
	},
    work_queue_name = work_queue_name,
    path = folder.replace('.','/'),
    apply = True
	)

infra_overrides takes an array

passing anything but dictionary gives the error -

value is not a valid dict (type=type_error.dict)

I am doing it like this which creates the deployment successfully but doesn't show the customizations applied on pod

see in my code on the deploy we just say infra_overrides = infra_overrides

and in infra_overrides you are passing something similar to what I have wrote if I understood it correctly from the resourcePatch append you are doing to the list