https://prefect.io logo
Powered by
Title
c

Christian Nuss

04/08/2022, 5:32 PM
heyo! i'm using 
prefect agent docker start
... is there a way to prevent the container from being removed once its completed?
k

Kevin Kho

04/08/2022, 5:39 PM
Hey, I’m not sure honestly. Looking at it, but would you happen to know how to do it without Prefect?
c

Christian Nuss

04/08/2022, 5:40 PM
usually exited containers stick around, i have to assume prefect is doing the equivalent of 
docker create ...
docker run ... --rm
usually i don't 
docker run ... --rm
k

Kevin Kho

04/08/2022, 5:45 PM
Prefect specifically uses create_container of docker-py so I am looking to see if it can be passed in as a kwarg but not seeing anything. The API doc is here for reference
z

Zanie

04/08/2022, 5:48 PM
We set this here 
# By default, auto-remove containers
        host_config: Dict[str, Any] = {"auto_remove": True}
You can set the 
auto_remove=False
on the run config host config which gets merged here
if run_config is not None and run_config.host_config:
            # The host_config passed from the run_config will overwrite defaults
            host_config.update(run_config.host_config)
c

Christian Nuss

04/08/2022, 5:50 PM
lemee try that, standby!
z

Zanie

04/08/2022, 5:51 PM
I’d accept an agent level toggle for the default behavior as in https://github.com/PrefectHQ/prefect/pull/4351
If you’d like to contribute 🙂
c

Christian Nuss

04/08/2022, 5:54 PM
is host_config actually the right place?
z

Zanie

04/08/2022, 5:55 PM
Yeah it is
Well, I think it is. We definitely set it to 
True
there.
c

Christian Nuss

04/08/2022, 5:56 PM
my type linter is complaining, i'll see what i'm doing wrong... prob a environmental issue
z

Zanie

04/08/2022, 5:56 PM
https://docker-py.readthedocs.io/en/stable/api.html#docker.api.container.ContainerApiMixin.create_host_config
We just type it as a 
dict
internally
c

Christian Nuss

04/08/2022, 6:15 PM
yea hmm, even register-flow is complaining about using 
host_config={auto_remove=False}
🤔
root@ca683cf00884:/app# prefect version
1.1.0
what i'm really really trying to solve is the container is starting, then stopping, but Prefect only show that it was submitted, not failed... not getting any signal as to why its failing
no logs for the flow run other than that the container was submitted for execution, and it stays in the Scheduled state...
i'm volume linking in our code and pickled prefect from the host OS, so i figure something is wrong there, just not what, specifically
k

Kevin Kho

04/08/2022, 6:26 PM
I think it should be: 
host_config={"auto_remove":False}
? Or were you just typing and that’s not a copy paste?
c

Christian Nuss

04/08/2022, 6:27 PM
omg rookie mistake sorry
so used to JS/TS in life where i don't have to quote map keys 🤦‍♂️
ah hah! its a networking issue... 
requests.exceptions.ConnectionError: HTTPConnectionPool(host='apollo', port=4200): Max retries exceeded with url: /graphql (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x400a087ad0>: Failed to establish a new connection: [Errno 111] Connection refused'))
still very strange that didn't end up in flow logs and the job stays in Submitted state... feels like a bug? perhaps a race condition when the container is launched, fails, and gets rm'd before prefect agent can gather logs?
k

Kevin Kho

04/08/2022, 6:34 PM
Stuck in submitted means the flow process never started, which is the thing that sends the logs to Cloud. So it’s not a bug necessarily, but more like there was nothing to send the logs. This also happens when a Kubernetes job couldn’t get the hardware it needed for example
So these will eventually get marked as Failed is they are retried enough times and it couldn’t get past a submitted state
z

Zanie

04/08/2022, 6:42 PM
It can’t send logs / update its state if it can’t contact the API
Here it looks like it’s trying to connect to 
apollo
as the API url, are you running your server on the same machine as your agent?
c

Christian Nuss

04/08/2022, 6:42 PM
ahhhh yes that makes sense
i added 
--network
to 
prefect agent docker start
and got past the issue!
z

Zanie

04/08/2022, 6:43 PM
👍 yep that was the next recommendation
c

Christian Nuss

04/08/2022, 6:44 PM
stellar, i'll look into an PR for the agent to get a little more customization for the remove behavior like Kube
thanks!
12 Views
#prefect-serverJoin Slack
Powered by