https://prefect.io
Join Slack
Hi, would someone be able to review <https://github.com/PrefectHQ/prefect/pull/19498> ? Thanks!
# ask-community
c
Hi, would someone be able to review https://github.com/PrefectHQ/prefect/pull/19498 ? Thanks!
n
can you add some context in the PR explaining why you want to make that change?
c
Done! We are seeing that error on our deployment (due to overloaded server)
n
hrm
it seems like this would cause incorrect retries on configuration errors
c
Good point. Do you think it's better to put this retry somewhere else?
n
i guess my initial reaction is that this is like a bare 
except
but for your server if you're seeing ConnectError, there's probably a reason why that one shouldn't try to gloss over as a rule. ie, the client implementation would be letting you down by not letting you know but i could be convinced otherwise / might be missing something
let me look into this a bit more
👍 1
chatted internally and we're sort of on the same page about this i don't think retrying on 
ConnectError
would be a net positive for users. it would prolong discovering configuration errors and discovery of the root issue, which in this case seems to be your overloaded server
c
Makes sense. Thanks for the feedback! Will find an alternative workaround
👍 1
4 Views
Open in Slack
PreviousNext
Powered by

Prefect Community

Bring your towel and join one of the fastest growing data communities. Welcome to our second-generation open source orchestration platform, a completely rethought approach to dataflow automation.

Powered by