Hi would someone be able to review <https github com Prefect Prefect Community #ask-community

Join Slack

Hi, would someone be able to review <https://githu...

# ask-community

Chu

11/25/2025, 4:25 PM

Hi, would someone be able to review https://github.com/PrefectHQ/prefect/pull/19498 ? Thanks!

Nate

11/25/2025, 4:32 PM

can you add some context in the PR explaining why you want to make that change?

Chu

11/25/2025, 4:34 PM

Done! We are seeing that error on our deployment (due to overloaded server)

Nate

11/25/2025, 4:42 PM

hrm

Nate

11/25/2025, 4:43 PM

it seems like this would cause incorrect retries on configuration errors

Chu

11/25/2025, 4:45 PM

Good point. Do you think it's better to put this retry somewhere else?

Nate

11/25/2025, 4:47 PM

i guess my initial reaction is that this is like a bare

except

but for your server if you're seeing ConnectError, there's probably a reason why that one shouldn't try to gloss over as a rule. ie, the client implementation would be letting you down by not letting you know but i could be convinced otherwise / might be missing something

Nate

11/25/2025, 4:49 PM

let me look into this a bit more

👍 1

Nate

11/25/2025, 5:05 PM

https://github.com/PrefectHQ/prefect/pull/19498#issuecomment-3576655343

Nate

11/25/2025, 5:06 PM

chatted internally and we're sort of on the same page about this i don't think retrying on

ConnectError

would be a net positive for users. it would prolong discovering configuration errors and discovery of the root issue, which in this case seems to be your overloaded server

Chu

11/25/2025, 5:07 PM

Makes sense. Thanks for the feedback! Will find an alternative workaround

👍 1

5 Views

Open in Slack

Previous Next