Hi folks. I'm trying out Prefect and running some pretty basic flows to get a feel for how developme...

Brian Mesick

10/25/2019, 5:44 PM

Hi folks. I'm trying out Prefect and running some pretty basic flows to get a feel for how development works. I'm curious if anyone is actually using the Snowflake task as it seems to have a bug that I would expect to render it unusable.

Brian Mesick

10/25/2019, 5:47 PM

https://github.com/PrefectHQ/prefect/blob/master/src/prefect/tasks/snowflake/snowflake.py#L101 is calling

execute

on the Snowflake Connector cursor with a

query

param that doesn't seem to exist: https://github.com/snowflakedb/snowflake-connector-python/blob/master/cursor.py#L424

Brian Mesick

10/25/2019, 5:48 PM

Changing that line to

executed = cursor.execute(query, params=data)

did work for me, however.

Chris White

10/25/2019, 5:50 PM

Hi Brian, this task was contributed by a user who presumably was using it; that being said, I see the bug and we’d definitely appreciate a PR which fixes it!

Brian Mesick

10/25/2019, 5:51 PM

Sure thing, just wanted to make sure I wasn't missing something obvious.

👍 1

Jeremiah

10/25/2019, 5:54 PM

It looks like the Python Snowflake library had a 2.0 release a couple weeks ago - this could be a breaking change it introduced

Brian Mesick

10/25/2019, 5:55 PM

This signature doesn't seem to have changed going back to at least 1.3.8

Mark McDonald

10/26/2019, 7:29 PM

looks like the arguments name should be

command

, rather than

query

https://github.com/snowflakedb/snowflake-connector-python/blob/54d4fa33306e24a39cbe6596bc8927990d8ef153/cursor.py#L424

Mark McDonald

10/26/2019, 8:01 PM

I threw up a PR for it: https://github.com/PrefectHQ/prefect/pull/1663

💯 2

2 Views

Open in Slack

Previous Next

Prefect Community

Bring your towel and join one of the fastest growing data communities. Welcome to our second-generation open source orchestration platform, a completely rethought approach to dataflow automation.