https://prefect.io logo
Title
a

Alexander Hirner

04/23/2020, 6:24 PM
Hello, one question regarding new-type `Result`s: what is planned to happen to
store_safe_value
? At first sight, it seems to be redundant to `Result`'s formatted location.
👀 1
l

Laura Lorenz (she/her)

04/23/2020, 6:27 PM
You’re exactly right!
store_safe_value
is going away from the pipeline code. You might be interested to see the current latest and greatest on that in this PR: https://github.com/PrefectHQ/prefect/pull/2391/files From the cloud perspective, which is what
store_safe_value
was all about, we serialize a `Result`s formatted filename direct off its attribute instead of through the
SafeResult
interface, since it’s available there now.
a

Alexander Hirner

04/23/2020, 6:32 PM
This looks like the missing puzzle piece. Thx for digging it up Laura, and the amazing work on PIN-16 as well!
Without too much digging, one more question: will
target: Result
or
:Type[Result]
still be necessary for the desired caching behaviour?
l

Laura Lorenz (she/her)

04/23/2020, 6:56 PM
That is the idea, though tbh we are still deciding to some degree how it will merge or coexist with the existing convenient `cache_key`/`cache_for`/etc task kwargs
👍 1
If you have any opinions on that and/or any psudocode of how you’d ideally configure caching using new style Results if you could, please do let me know 🙂
a

Alexander Hirner

04/23/2020, 7:05 PM
will do!