but its not taking the values