Scott Zelenka
07/01/2020, 3:06 PMS3Result
instead of S3ResultHandler
, do we need to have a PrefectSecret named AWS_CREDENTIALS
?
Previously with S3ResultHandler
there was a kwarg for `aws_credentials_secret`(which allowed us to specify different credentials for different Flows), but that doesn't seem to be present on the new S3Result
. Trying to figure out how to pass those credentials to S3Result
josh
07/01/2020, 3:17 PMAWS_CREDENTIALS
would be your best bet https://docs.prefect.io/core/concepts/secrets.html#default-secrets as the S3Result
does not accept credentials directly. The S3Result
does not currently allow for passing in credentials directly to the result however the client it uses has an option for it https://github.com/PrefectHQ/prefect/blob/master/src/prefect/utilities/aws.py so we could expose this on the Result classS3Result
has an option for boto3_kwargs
which you can set boto3 credentials in if you chooseS3Result(boto3_kwargs={"aws_access_key_id": "...", etc.})
Scott Zelenka
07/01/2020, 3:45 PMAWS_CREDENTIALS
secret for both use cases.josh
07/01/2020, 3:49 PMget_boto_client
utility and still have it use a default of AWS_CREDENTIALS
Scott Zelenka
07/01/2020, 3:50 PMjosh
07/01/2020, 3:50 PM