This is a pathological case, but it seems possible...
# prefect-communityb
Ben Fogelson
07/14/2020, 7:09 PMThis is a pathological case, but it seems possible to end up with multiple tasks in the same flow having the same slug:
Copy code
import prefect as p
@p.task
def add_one(n):
return n + 1
@p.task
def add_two(n):
return n + 2
with p.Flow('f') as f:
a = p.Parameter('a')
b = add_one(a)
b.slug = 'my_slug'
c = add_two(a)
c.slug = 'my_slug'
f.get_tasks(slug='my_slug') # returns both tasks
f.validate(). # passesj
Jim Crist-Harif
07/14/2020, 7:15 PMHmmm, once a task is added to a flow we only check the set of slugs stored on the flow, not on the task itself. Modifying the slug of a task is frowned upon - perhaps we should disable that behavior.
Jim Crist-Harif
07/14/2020, 7:16 PMNote that if you set the slug on the task before adding it to the flow, it will error appropriately.
Jim Crist-Harif
07/14/2020, 7:17 PM Copy code
import prefect as p
@p.task
def add_one(n):
return n + 1
@p.task
def add_two(n):
return n + 2
with p.Flow('f') as f:
a = p.Parameter('a')
b = add_one(a, task_args={"slug": "my_slug"})
c = add_two(a, task_args={"slug": "my_slug"})Jim Crist-Harif
07/14/2020, 7:34 PMYou shouldn't need to set the
slugslugb
Ben Fogelson
07/14/2020, 7:36 PMSweet! That’ll do it 👍
i
itay livni
07/14/2020, 7:36 PMWhen I was playing around with slugs for
targetsmerge_parametersI wouldn't expect users to really interact with `slug`s honestly - the main purpose of a slug is to have a stable ID that allows the Prefect API to determine which Python object is undergoing state updates. Slugs are not an inherent property of tasks, they're a property of tasks within flows, hence the move away from storing them on task objects directly.
j
Jeremiah
07/14/2020, 8:30 PM
When we added the new
slugvalidate()validate()3 Views