https://prefect.io logo
a

Alberto de Santos

10/14/2020, 7:51 PM
Can anyone tell me how to get rid of these labels: ”
Copy code
'azure-flow-storage', 'gcs-flow-storage', 's3-flow-storage',
      'github-flow-storage', 'webhook-flow-storage'
Even when setting up the TOML file with labels, they still appear.
r

Raphaël Riel

10/14/2020, 7:55 PM
Haven’t found a way other than Subclassing Agent/LocalAgent. They are added straight in the Constructor of LocalAgent:
Why would you want to remove those?
a

Alberto de Santos

10/14/2020, 7:55 PM
they are annoying me
🙂
r

Raphaël Riel

10/14/2020, 7:56 PM
Haha, we have the same disease 😛
a

Alberto de Santos

10/14/2020, 7:56 PM
understood 🙂
makes me feel better
😂 2
The issue is that Agent and Flow should have the same labels, right? Or at least Flow’s should be a subset of the Agent’s, right?
j

josh

10/14/2020, 7:59 PM
We could definitely add a flag to remove these on the agent
r

Raphaël Riel

10/14/2020, 7:59 PM
Flow will only run on an agent that has at least all of the Flow’s labels.
⬆️ 1
c

Chris White

10/14/2020, 8:00 PM
There’s an open issue for this here: https://github.com/PrefectHQ/prefect/issues/3242
a

Alberto de Santos

10/14/2020, 8:00 PM
Exactly, @Raphaël Riel, that’s what I meant. Then we are everybody in the same page.
Understood and glad I don’t have to fight any longer with this
I think this community is awesome!
🚀 3
Thanks
r

Raphaël Riel

10/14/2020, 8:03 PM
Put my 2cents on the Issue 😛 Thanks @Chris White for the Ref.
c

Chris White

10/14/2020, 8:03 PM
you got it - we can prioritize this for the next release!
r

Raphaël Riel

10/14/2020, 8:03 PM
If you like my suggestion on GH, just poke me and I’ll try to open a PR with this.
j

josh

10/14/2020, 8:06 PM
@Raphaël Riel definitely we encourage the contribution! I’m thinking what we need is the local agent has some kwarg like
default_labels
which defaults to
True
and then the
prefect agent start
command can take in a flag that passes that value to the local agent it starts 🙂
r

Raphaël Riel

10/14/2020, 8:07 PM
Gotcha.
@Alberto de Santos Gift for you: https://github.com/PrefectHQ/prefect/pull/3503
a

Alberto de Santos

10/15/2020, 4:13 PM
Amazing @Raphaël Riel !!