The flow run names (e.g.

daffy-wolf

) already look very docker-name like It seems like it'd be pretty slick if the

DockerAgent

then also used the same name for launching containerized flows. Not strictly needed, and maybe only relevant for our setup where our log aggregator shows the container name that the logs came from

That sounds like a good feature request @Jonathan Chu! Feel free to open a ticket or discussion in the Core repo 😄

Hmm. Unfortunately the container names need to be unique so at best we could do

<flow-name>-<flow-run-id>

I think it's the opposite - flow run names aren't guaranteed to be unique but flow run ids are

oh sorry, ignore that, i misread that completely

Yeah otherwise the agent may run into errors spawning containers. We could do a more complex patch that appends

-{index}

by checking for existing containers first

and i'd figure that containers would probably also tend not to be long-lived, so most of the time you wouldn't need to append the index, just need it to ensure no whammies

Exactly yeah we just wouldn't want it to break things 🙂

hah, i was still writing up the github issue for this

Unfortunately we don't build images for non-master builds so to test this with docker-in-docker you'd have to build a new image or clone prefect in a docker container and checkout the branch.

restarted our agents to pick up the new version