https://prefect.io logo
Channels
Powered by
b

brian

02/22/2022, 5:21 PM
Hi all, I’m trying to use a secret in a state handler but it doesn’t seem to be working
I’m using prefect cloud and have setup a secret 
MU_SENTRY_DSN
k

Kevin Kho

02/22/2022, 5:22 PM
PrefectSecret won’t work but 
Secret(…).get()
will inside a state handler. Or maybe 
PrefectSecret().run()
b

brian

02/22/2022, 5:22 PM
I made some modifications to this snippet
Copy code
import prefect

prefect.context.setdefault("secrets", {}) # to make sure context has a secrets attribute
prefect.context.secrets["MY_KEY"] = "MY_VALUE"
s/MY_KEY/MU_SENTRY_DSN/
Copy code
def _handle_flow_states(obj, old_state, new_state):
    if new_state.is_running():
        logger = prefect.context.get("logger")
        <http://logger.info|logger.info>("flow is running, initializing sentry sdk")
        # make sure context has a secrets attribute
        # see this <https://docs.prefect.io/api/latest/client/secrets.html#secret>
        prefect.context.setdefault("secrets", {})
        sentry_sdk.init(dsn=prefect.context.secrets["MU_SENTRY_DSN"])
        <http://logger.info|logger.info>("initialized sentry sdk")
    return new_state
k

Kevin Kho

02/22/2022, 5:22 PM
This won’t work because the context is already loaded in when you import Prefect and is not mutable one it’s created.
b

brian

02/22/2022, 5:24 PM
But if the secret is set, shouldn’t the 
setdefault
call do nothing? i.e. prefect.context.secrets should already be a dict?
k

Kevin Kho

02/22/2022, 5:24 PM
It would work if you did something like:
Copy code
import os
os.environ["PREFECT__CONTEXT__SECRETS__MY_KEY"]
import prefect
b

brian

02/22/2022, 5:25 PM
Hmm ok. I think one thing I missed is that the code snippet is intended for setting a secret
k

Kevin Kho

02/22/2022, 5:25 PM
So Prefect doesn’t pull in secrets that are already set automatically unless it’s included in the storage when you register like:
Copy code
flow.storage = SomeStorage(...,secrets=[])
b

brian

02/22/2022, 5:25 PM
While I’m trying to get
There are a handful of other secrets I’ve setup in prefect cloud for this flow that seem to be working But these were all passed in as inputs to tasks
You’re saying that these secrets ^ are actually being set at register-time?
So when I configure my GitHub storage I should do something like this?
Copy code
flow.storage = GitHub(
   repo="...",
   path="...",
   secrets=["MU_SENTRY_DSN"],
)
k

Kevin Kho

02/22/2022, 5:29 PM
So if you have a Flow and you do 
PrefectSecret
like
Copy code
with Flow() as flow:
    PrefectSecret("something")
this is pulled during runtime because it’s a task and the task has deferred execution So if you do it in a state handler, to pull it immediately:
Copy code
def mystatehandler(task, old_state, new_state):
    PrefectSecret("something").run()
    # or
    Secret("something").get()
I am less sure PrefectSecret will work in the state handler. Secret.get() is preferred outside of the Flow
For it to appear in context yep you can add it to the secrets like that when you register
5 Views
Powered by