Channels
announcements
ask-marvin
best-practices-coordination-plane
data-ecosystem
data-tricks-and-tips
events
find-a-prefect-job
geo-bay-area
geo-berlin
geo-boston
geo-chicago
geo-colorado
geo-dc
geo-israel
geo-japan
geo-london
geo-nyc
geo-seattle
geo-texas
gratitude
introductions
marvin-in-the-wild
pacc-clearcover-june-12-2023
pacc-may-31-2023
ppcc-may-16-2023
prefect-ai
prefect-aws
prefect-azure
prefect-cloud
prefect-community
prefect-contributors
prefect-dbt
prefect-docker
prefect-gcp
prefect-getting-started
prefect-integrations
prefect-kubernetes
prefect-recipes
prefect-server
prefect-ui
random
show-us-what-you-got
Title
m
Mathijs Schoorl
03/05/2021, 2:12 PMI'm playing around with the trigger manual_only. Which seems to work great. Just something I can not really find a good answer to: Is it possible to only ask for an approval if all upstream tasks are successful? It looks like manual_only means it will always ask for approval and keeps the flow running. I would like to have an approval task fail with the status TRIGGERFAIL if any upstream tasks are in a failed state.
n
nicholas
03/05/2021, 4:03 PMHm - I think your best bet here might be to add a task upstream to your manual task that will only continue on
all_successfulm
Mathijs Schoorl
03/05/2021, 4:27 PMI don't think that will work. As far as I know a task with a trigger
all_successfulmanual_onlyn
nicholas
03/05/2021, 4:34 PMYou know I think you're right
I think this is worth opening a ticket on the Core repo
Would you mind doing that and describing what your desired behavior would be?
One option in the interim might be to use a
casecontrol_task = ControlTask(trigger=all_successful)(upstream_tasks=[fail_on_purpose])
with case(control_task, True):
approve = ApproveTransfer(trigger=manual_only)(upstream_tasks=[control_task])m
Mathijs Schoorl
03/05/2021, 4:38 PMI'll give that a try after the weekend. Depending on the outcome I'll create a ticket in the Core repo. Thanks!
n
nicholas
03/05/2021, 4:41 PMSounds good - have a nice weekend! 🙂
Ah sorry @Mathijs Schoorl - I gave you incomplete advice, you can also write a custom trigger with the form:
trigger_fn(upstream_states: Set[State]) -> boolm
Mathijs Schoorl
03/08/2021, 7:03 PMCreating my own trigger worked great, thanks:
def manual_trigger_adv(upstream_states: Dict["core.Edge", "state.State"]) -> bool:
if not all(s.is_successful() for s in _get_all_states_as_set(upstream_states)):
raise signals.TRIGGERFAIL(
'Trigger was "manual_only" but some of the upstream tasks failed.'
)
if context.get("resume"):
return True
raise signals.PAUSE('Trigger function is "manual_only"')😄 1