Channels
announcements
ask-marvin
best-practices-coordination-plane
data-ecosystem
data-tricks-and-tips
events
find-a-prefect-job
geo-bay-area
geo-berlin
geo-boston
geo-chicago
geo-colorado
geo-dc
geo-israel
geo-japan
geo-london
geo-nyc
geo-seattle
geo-texas
gratitude
introductions
marvin-in-the-wild
pacc-clearcover-june-12-2023
pacc-may-31-2023
ppcc-may-16-2023
prefect-ai
prefect-aws
prefect-azure
prefect-cloud
prefect-community
prefect-contributors
prefect-dbt
prefect-docker
prefect-gcp
prefect-getting-started
prefect-integrations
prefect-kubernetes
prefect-recipes
prefect-server
prefect-ui
random
show-us-what-you-got
Title
c
Christian Nuss
03/14/2022, 6:20 PMHey there again everyone! Hopefully a quick question about doing a
create_flow_run.run(flow_name="flow-2")KubernetesRunwith Flow("flow-1", run_config=KubernetesRun(...)):
... creates task that does a create_flow_run.run(flow_name="flow-2") ...flow-2run_configflow-1k
Kevin Kho
03/14/2022, 6:21 PMThere is no RunConfig inheritance. It has to be defined on the subflow, but I think you can explicitly pass a new RunConfig as well if you want. It’s more common though to pass parameters down to link the parent and child
create_flow_runc
Christian Nuss
03/14/2022, 6:22 PMthanks @Kevin Kho then thats what i experienced and wanted to make sure i wasn't crazy or doing something wrong!
also: your response time for questions here is on point! ⭐⭐⭐⭐⭐
:upvote: 1
👍 1
k
Kevin Kho
03/14/2022, 6:23 PMThank you!
w
William Grim
03/14/2022, 6:28 PM@Kevin Kho in this case, “flow-2” would also have been defined, registered, and serialized with a KubernetesConfig. i think @Christian Nuss was seeing that it wasn’t working though? i.e. the labels defined in the flow being called from the first KubernetesRun weren’t set
i worded that awkwardly. let me rephrase
I believe he was seeing that the registered flow, which was being called by the first flow, which was instantiated as a KubernetesRun, wasn’t getting its run_config labels set on it when it was instantiated, even though it’s defined in the flow itself. Is that right @Christian Nuss?
still awkward, but hopefully less so…
c
Christian Nuss
03/14/2022, 6:29 PMright correct as @William Grim said, we have a
with Flow("flow-2", run_config=KubernetesRun(...)):k
Kevin Kho
03/14/2022, 6:32 PMAh ok so you have a subflow registered with KubernetesRun but it doesn’t seem respected? What do you see when you go to the Flow page in the UI? There should be a space for RunConfig and labels?
c
Christian Nuss
03/14/2022, 6:32 PM1 sec, standby...
😂 1
strange its adding a nonsense label
so its not getting scheduled
k
Kevin Kho
03/14/2022, 6:37 PMAh ok before you register, you can do:
flow.storage.add_default_labels = FalseWait so you have pending runs but the create_flow_run is working right?
c
Christian Nuss
03/14/2022, 6:38 PMcreate_flow_run does appear to be working, as the new sub-flow gets registered and the run config looks correct!
so just a labeling issue
k
Kevin Kho
03/14/2022, 6:39 PMGotcha yeah just remove the default label and I think this should be good. What storage are you using though? Normally the default label is attached to local storage
c
Christian Nuss
03/14/2022, 6:42 PMi made some hackery in this case with volume mounts for Local Development purposes
k
Kevin Kho
03/14/2022, 6:42 PMOhhh yes ok that sounds good and you can turn off the default label that is part of Local storage
c
Christian Nuss
03/14/2022, 6:44 PM🚀
worked like a charm, thx!
👍 3
in Production we will use S3 Storage + Kube, do you think i should add the
add_default_labels=Falsew
William Grim
03/14/2022, 6:57 PM@Christian Nuss i believe the “nonsense label” is your instance’s “hostname”
:upvote: 1
a
Anna Geller
03/14/2022, 7:17 PMno need for add_default_labels when using S3 storage - it's only applied when using local storage and William is correct, this cac0475... is the hostname of your machine 🙂