https://prefect.io logo
Title
j

Joseph

12/17/2020, 10:28 PM
(I incorrectly posted this issue in the server channel and had a thread with @nicholas. Now that I have more information, moving it here.) I can cause a browser crash by visiting the “schematic” tab with a small dag that has 100 root nodes that each have 1 child. I was able to track this down to a very specific d3-dag call. I created a minimal repro and filed it with the author of d3-dag (https://github.com/erikbrinkman/d3-dag/issues/52). What I’d like to know is: is there a work-around or is it possible to get patch for my installation of Prefect? I’m performing an evaluation and this has become a blocking issue, so I’d like to know what’s the right next step (wait for fix? find work around? maybe it will be obviated in the next release?). Thanks!
n

nicholas

12/17/2020, 10:31 PM
Hi @Joseph - thanks for looking into this! If this is the cause, we can swap our sorting algorithm for the time being but I'll need to take a look at some samples to make sure it doesn't have any unexpected results in other schematics. Let me see if we can get something out tomorrow 🙂
j

Joseph

12/17/2020, 10:31 PM
Awesome! Thanks!
n

nicholas

12/17/2020, 10:32 PM
(btw erik is usually pretty responsive so I wouldn't be surprised if he had a fix out soon.. unfortunately due to some other changes in the package we can't upgrade the UI dependency just yet... issue for that is open here: https://github.com/PrefectHQ/ui/issues/318)
Hi @Joseph - just following up on this, I should be able cut a release today to fix this issue 🙂
🙌 1
j

Joseph

12/18/2020, 8:30 PM
(Erik did respond to the ticket - said it is the wrong algo to use for any large graphs)
n

nicholas

12/18/2020, 8:43 PM
Yeah, after reading through their implementation it makes sense why it's nonperformant 👍
j

Joseph

12/18/2020, 11:24 PM
Thanks again for getting that in. If I’ve installed via pip, what’s the typical delay between your merge to master and the pip installer being updated?
n

nicholas

12/18/2020, 11:25 PM
That’ll go out with the next core release, though Cloud will be updated on the next UI release (which’ll be tonight most likely)
j

Joseph

12/18/2020, 11:25 PM
Ok thanks - maybe I’ll just move over to a git-based install
n

nicholas

12/18/2020, 11:26 PM
Ok! I’ll ping you when this is ready then :)