https://prefect.io logo
Title
a

Alex Cano

06/08/2020, 4:01 PM
Did the tests for code formatting & mypy get removed? I just realized after my vscode stopped auto-black formatting my code and it failed CI checks 😅
l

Laura Lorenz (she/her)

06/08/2020, 4:05 PM
mypy and black don’t autorun with
pytest
, if that’s where you’re referring to, but do run in circleCI, if that answers your question. tbh in my case i run
black
myself whenever I remember, and don’t ever notice mypy until circleCI runs it :)
:upvote: 1
a

Alex Cano

06/08/2020, 4:08 PM
I think they used to, right? Like there was a
test_formatting.py
file? I just know that I never notice if vscode stops auto-blackening the code before pushing. Any chance we could add these tests back in? Maybe have them be opt-in instead of opt-out?
l

Laura Lorenz (she/her)

06/08/2020, 4:35 PM
ah ok, there is a test_formatting for server only that runs mypy and black locally. but your recent PR is for core is I think the confusion
c

Chris White

06/08/2020, 4:38 PM
Yea these were updated recently: https://github.com/PrefectHQ/prefect/pull/2525
🕸️ 1