Made a little connector for Gsheets - not sure why...
# prefect-contributors-archived
m
Made a little connector for Gsheets - not sure why the build is failing? https://github.com/PrefectHQ/prefect/pull/2614
c
Hi @matta - it appears there are a few minor stylistic changes you need to make for the builds to succeed: - there are some unused imports in
gsheets.py
, in particular you should replace this one import line as follows:
Copy code
-from typing import List, Union, Any, TypedDict, Callable
+from typing import Any, Callable, List, Union
-
row
is an undocumented argument of your
ReadGsheetRow
task - the docstring for
gsheet_helper
isn’t quite right: the helper only takes a
fn
function that needs to be documented With these 3 changes the builds should start succeeding!
m
Sweet, thanks!
So, I made the first two, but the thing with the
gsheet helper
is that it's basically a "wrapper" way to turn anything you can do through the
gsheets
package (making new pages, different kinds of selection, searches) and turn them into a Prefect task. Not sure if that's unsound or maybe "un-Prefect-ic"?
So it'd be hard to fully document it beyond that it'd be a
Callable
.
c
yea that’s fine - we have strict doc requirements that all arguments (and no more) be documented; if you don’t think it needs to be publicly documented you could remove it from
docs/outline.toml
and the docstring won’t be checked
m
Ah, k! Thanks!