General question about the

server

repo. Are there plans to make it mypy compliant? Just a tad confused because there are mypy configurations in

setup.cfg

but mypy isn’t a required package for dev

There were plans a long time ago to make it mypy compliant but it’s honestly been more of a nuisance in Core so we abandoned those plans

Abandoned them for both server and core? Did it have something to do with the

@task

decorator, by chance? That seems like a place mypy would freak out haha

haha we do still enforce mypy checks in Core actually, but we ignore some files 😛

Ahhhh good to know! Thoughts on adding it into server? Reason I ask is that I have a couple of free hours and thought that could be a decent use of time!

honestly maintaining it is such a pain, so feel free to update the types but we probably won’t enforce them via tests

Ahh good to know… it sounds like there might be some war stories between you and mypy? I’ve found that in my codebases (significantly more straightforward than Prefect, may I add) that it’s only ever caught errors. Do you find mypy getting things wrong often? Or just needs a larger amount of work to write “compliant” code

haha yes many many war stories; I’ve found mypy is bad at variance / contravariance, and we have so many

assert blah is not None

or

assert isinstance(blah, list)

to get mypy to recognize the type. @Jim Crist-Harif has some strong opinions on this as well I think

Ahhh, good to know! And Jim would leave to hear your thoughts on it too!