https://prefect.io logo
a

Alex Cano

09/22/2020, 7:04 PM
Hey yall, question for ya: What is the
labeler
in github actions? It looks like the action is failing on this PR: https://github.com/PrefectHQ/server/actions/runs/266743999
c

Chris White

09/22/2020, 7:09 PM
Hey Alex - it looks at what code files were touched and labels the PR accordingly; really not sure why it would fail
a

Alex Cano

09/22/2020, 7:14 PM
Interesting… has it failed before? Or is this a new and exciting world we are living in?
c

Chris White

09/22/2020, 7:18 PM
haha I’ve never seen it fail and in fact, here’s an open contributor PR where it succeeded: https://github.com/PrefectHQ/server/pull/57
a

Alex Cano

09/22/2020, 7:27 PM
Lovely… Looking through the labeler action too, for the history of the server repo, this PR is the only one to ever fail the labeler. I’ll probably have more time to look into it this weekend
c

Chris White

09/22/2020, 7:28 PM
hm so odd - yea sorry for letting the PR sit, I haven’t had a chance to review it yet
as this recreates functionality in Cloud, it’ll be a bit messy because I need to make sure we can maintain two separate implementations / that they’re compatible
👍 1
a

Alex Cano

09/22/2020, 7:30 PM
Kk, let me know if there’s anything I can do to make it more modular / composable too. It’d be great to be able to minimize the surface area where the implementations actually differ
c

Chris White

09/22/2020, 7:30 PM
yup for sure!
a

Alex Cano

09/22/2020, 7:35 PM
Also, just realized what it could be. My default git setup is for gitlab (for my day job), so I didn’t set the user information yet on this new repo. Maybe it’s freaking out because it doesn’t know who the author is?
c

Chris White

09/22/2020, 7:38 PM
hmm maybe? that seems surprising though and I’d expect a more informative error message
a

Alex Cano

09/22/2020, 7:39 PM
Oh definitely… at this point, I’m just trying to think why mine would fail while other contributors would succeed, and that stuck out. I’ll try and replay those commits later this week when I have some time and re-push
c

Chris White

09/22/2020, 8:03 PM
yea for sure 🧐
@Alex Cano “good news” - this is now failing on one of our PRs as well: https://github.com/PrefectHQ/server/pull/97/checks?check_run_id=1161037407
a

Alex Cano

09/24/2020, 2:57 PM
Hahaha that is “good”… sounds like it might not take until the weekend to get looked at 😛
c

Chris White

09/24/2020, 2:58 PM
haha
4 Views