a

    Alex Cano

    2 years ago
    Hey yall, question for ya: What is the
    labeler
    in github actions? It looks like the action is failing on this PR: https://github.com/PrefectHQ/server/actions/runs/266743999
    Chris White

    Chris White

    2 years ago
    Hey Alex - it looks at what code files were touched and labels the PR accordingly; really not sure why it would fail
    a

    Alex Cano

    2 years ago
    Interesting… has it failed before? Or is this a new and exciting world we are living in?
    Chris White

    Chris White

    2 years ago
    haha I’ve never seen it fail and in fact, here’s an open contributor PR where it succeeded: https://github.com/PrefectHQ/server/pull/57
    a

    Alex Cano

    2 years ago
    Lovely… Looking through the labeler action too, for the history of the server repo, this PR is the only one to ever fail the labeler. I’ll probably have more time to look into it this weekend
    Chris White

    Chris White

    2 years ago
    hm so odd - yea sorry for letting the PR sit, I haven’t had a chance to review it yet
    as this recreates functionality in Cloud, it’ll be a bit messy because I need to make sure we can maintain two separate implementations / that they’re compatible
    a

    Alex Cano

    2 years ago
    Kk, let me know if there’s anything I can do to make it more modular / composable too. It’d be great to be able to minimize the surface area where the implementations actually differ
    Chris White

    Chris White

    2 years ago
    yup for sure!
    a

    Alex Cano

    2 years ago
    Also, just realized what it could be. My default git setup is for gitlab (for my day job), so I didn’t set the user information yet on this new repo. Maybe it’s freaking out because it doesn’t know who the author is?
    Chris White

    Chris White

    2 years ago
    hmm maybe? that seems surprising though and I’d expect a more informative error message
    a

    Alex Cano

    2 years ago
    Oh definitely… at this point, I’m just trying to think why mine would fail while other contributors would succeed, and that stuck out. I’ll try and replay those commits later this week when I have some time and re-push
    Chris White

    Chris White

    2 years ago
    yea for sure 🧐
    @Alex Cano “good news” - this is now failing on one of our PRs as well: https://github.com/PrefectHQ/server/pull/97/checks?check_run_id=1161037407
    a

    Alex Cano

    2 years ago
    Hahaha that is “good”… sounds like it might not take until the weekend to get looked at 😛
    Chris White

    Chris White

    2 years ago
    haha