Not sure if this is the right channel for submitting PRs But

Question

Not sure if this is the right channel for submitting PRs But I have one to add chunking to GCS to enable handling of larger files or slower internet connections Not sure how to best add tests for this in CI <https github com PrefectHQ prefect pull 3968>

nicholas · Answer

Amazing thank you < Josh> pray The Core team will take a look at your PR when they can and will handle the review process through GitHub slightly smiling face

Zanie · Answer

I don t manage the core repo but I can point you towards the typical way to test something like this Since the GCS library has its own tests and is out of our control we just want to assert that if someone provides this new argument that it is properly passed to GCS The typical way to do this is to mock the GCS function then assert that if `chunk size` is given to one of these tasks that the object is created with that option set to the correct value

Zanie · Answer

An example of this is at `tests tasks gcp test gcs upload download TestBlob`

Zanie · Answer

And at `tests storage test gcs storage TestGCSStorage`

Zanie · Answer

Because the `blob` object we need to call assertions on is nested in several calls to the GCS library we have to do several mocks e g ``` blob mock = MagicMock bucket mock = MagicMock blob=MagicMock return value=blob mock google client return value get bucket = MagicMock return value=bucket mock ```

Zanie · Answer

The only one we re really interested in is our `blob mock` which we can assert was called with the `chunk size` argument