hi all – if I'm digging through some source code a...
# prefect-contributors-archiveds
Sean Talia
04/26/2021, 1:29 PMhi all – if I'm digging through some source code and notice that on an already-merged PR something was omitted that maybe should have been included in it, is there a preferred way to bring that to the community's attention? I'm thinking either to bring it up in this channel, the #CL09KU1K7 channel, or to actually comment on the since-merged PR. Is there a standard for this kind of thing?
Sean Talia
04/26/2021, 1:30 PMI suppose just opening up a PR would be another option
k
Kevin Kho
04/26/2021, 1:39 PM
Hi @Sean Talia! Is this for your own PR?
s
Sean Talia
04/26/2021, 1:40 PMactually it's for one of yours! it's super minor, just a documentation change
Sean Talia
04/26/2021, 1:41 PMcorrect me if I'm wrong but it seems like in this PR you changed the snowflake task to actually return the query results which it wasn't doing before (in
src/prefect/tasks/snowflake/snowflake.pySean Talia
04/26/2021, 1:42 PMthe docs for this task are still showing that the task returns
Nonefetchall()k
Kevin Kho
04/26/2021, 1:46 PM
You’re completely right here! Well this is perfect because I have another PR open on the same file and could slide it in. But if you want to, it seems you should open a PR directly for it.
s
Sean Talia
04/26/2021, 1:49 PMohhhhh nice!!! I am excited about that
SnowflakeQueriesFromFileSean Talia
04/26/2021, 1:50 PMokay I'm fine with opening up a separate PR, I can do that in the next day or two
k
Kevin Kho
04/26/2021, 3:06 PM
Sounds good! Thank you!
6 Views