Michael Wheeler

    Michael Wheeler

    1 year ago
    Hi everyone, I'm looking to see how people feel about handling this issue: https://github.com/PrefectHQ/server/issues/254 TLDR: there are quite a few places in the Prefect Server code where it's hard-coded to use http, which means that deployments will inexplicably break in an environment where https is the default. I feel like it would be an easy fix to simply add an additional configuration value, but @Kevin Kho encouraged me to solicit feedback here before I start work on a PR.
    Michael Adkins

    Michael Adkins

    1 year ago
    I'm scared this will require changes in both Server and Core and be more than it looks like, but I understand the intent here.
    I have a preference for something like
    ssl: true/false
    but then we can't template the string in the config
    The comment at https://github.com/PrefectHQ/server/issues/254#issuecomment-846260028 -- this check is during the command to clear the database and consequently we have some safeguards to prevent that from accidentally happening to a production database
    Michael Wheeler

    Michael Wheeler

    1 year ago
    I'm scared this will require changes in both Server and Core and be more than it looks like, but I understand the intent here
    Off the top of your head, in what other parts of the code do you think this could cause problems? Should I open up a related issue in the core repo to discuss it?
    Michael Adkins

    Michael Adkins

    1 year ago
    Well where you've pointed out the hard-coded values in the Server repo, those are all CLI tooling for running Server locally for development
    The Core repo redefines a bunch of Server settings for the
    prefect server start
    command and has its own
    docker-compose
    template file.
    Michael Wheeler

    Michael Wheeler

    1 year ago
    Gotcha yeah, I was actually just grepping through for that, making a list of the spots where those configs get used, mostly in
    src/prefect/cli/server.py
    . Let me go make that second issue to enumerate those changes then