Hi, is that possible to make <these create task ru...
# prefect-aws
a
Hi, is that possible to make these create task run retry settings as environment variables?
I saw that the repo is migrated to be part of
prefect
repo. So, new reference is these lines
@Kevin Grismore or @Nate Do you think it’s something to be considered as a minor version for this?
n
hi @Anh Pham
Do you think it’s something to be considered as a minor version for this?
sorry, I'm not sure I understand the question - what about a minor version?
a
@Nate Sorry for making confusions 🙈. Is that reasonable to release a new minor version of prefect-aws with these constants configurable through env vars?
n
no worries! thanks for clarifying - yes I think allowing specification of those constants via env vars would make a lot of sense in fact, I think we may want to use pydantic's
BaseSettings
for this to load settings automatically from environment - an issue expressing this on prefecthq/prefect
constants configurable through env vars
would be appreciated!
a
Yes. That would be awesome to have this using
BaseSettings
Is that a practice in prefect to use
pydantic
v2 already? if so,
pydantic-settings
should be added as well to the
requirements.txt
n
its a great question, unfortunately most of our internal objects are still v1 (note the conditional imports that exist today) so its a little bit trickier than it should be right now to use v2 (have to account for other installs, playing nice with v1 objects etc) since we will have to migrate
prefect-aws
later anyways and its not that hard to translate v1 -> v2
BaseSettings
I think we should just define a v1
BaseSettings
object that loads from env vars, not any
.env
file for no. one with a
PREFECT_AWS_
prefix
🙌 1
a
@Nate Is that true currently, pydantic v2 is using in prefect and prefect-aws already?
I could open a PR for this.
n
hi @Anh Pham - this is something I am working through now!
prefect-aws
might be a little tricky comparatively speaking because of all the blocks
the status quo was the v2 was installed but not actually used (we used the v1 backport in v2)
a
Hi @Nate, just checking-in as pydantic v2 migration is done. Should I open a new PR for this?