Channels
Hi, before propose a PR I opened an issue (<https:...
# prefect-contributors-archivedf
flapili
04/21/2023, 8:56 AMHi, before propose a PR I opened an issue (https://github.com/PrefectHQ/prefect/issues/9290), any advise about it ?
z
Zanie
04/21/2023, 4:01 PM
Ryan’s suggestion seems reasonable!
f
flapili
04/21/2023, 4:01 PMI'm felling dumb to not thinking myself to -m 😂
z
Zanie
04/21/2023, 4:02 PM
In general it’s not safe to just call into a venv like that. It’s fine if you’re calling
pythonZanie
04/21/2023, 4:02 PM
I’d recommend at least putting the
bin/PATHf
flapili
04/21/2023, 4:03 PMthat's sound bad, in the future I'll not understand where the binaries will come from 😅
flapili
04/21/2023, 4:05 PMFurthermore, all scripts installed in the environment should be runnable without activating it.
flapili
04/21/2023, 4:06 PMfro what I understood it's definitively safe for python, and should be safe (handled by the third party scripts devs) for scripts
z
Zanie
04/21/2023, 4:08 PM
Wouldn’t you just put it in the PATH for that single call?
Zanie
04/21/2023, 4:08 PM
I think “should be” can be pretty far from reality 🙂 but yeah I agree it should be fixed
f
flapili
04/21/2023, 4:10 PMI could but I hate shimming envs
flapili
04/21/2023, 4:10 PMit's evil to me x)
55 Views