https://prefect.io logo
Title
f

flapili

04/21/2023, 8:56 AM
Hi, before propose a PR I opened an issue (https://github.com/PrefectHQ/prefect/issues/9290), any advise about it ?
z

Zanie

04/21/2023, 4:01 PM
Ryan’s suggestion seems reasonable!
f

flapili

04/21/2023, 4:01 PM
I'm felling dumb to not thinking myself to -m 😂
z

Zanie

04/21/2023, 4:02 PM
In general it’s not safe to just call into a venv like that. It’s fine if you’re calling
python
(as you noted in the docs) but calling into other libraries can encounter problems like this.
I’d recommend at least putting the
bin/
in your
PATH
but I’m down to improve our behavior here as well
f

flapili

04/21/2023, 4:03 PM
that's sound bad, in the future I'll not understand where the binaries will come from 😅
Furthermore, all scripts installed in the environment should be runnable without activating it.
fro what I understood it's definitively safe for python, and should be safe (handled by the third party scripts devs) for scripts
z

Zanie

04/21/2023, 4:08 PM
Wouldn’t you just put it in the PATH for that single call?
I think “should be” can be pretty far from reality 🙂 but yeah I agree it should be fixed
f

flapili

04/21/2023, 4:10 PM
I could but I hate shimming envs
it's evil to me x)